Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optimizelyClient validity check fixed #289

Closed
wants to merge 2 commits into from
Closed

fix: optimizelyClient validity check fixed #289

wants to merge 2 commits into from

Conversation

ozayr-zaviar
Copy link
Contributor

Summary

  • get_optimizely_config replaced with is_valid in forced decision optimizelyClient object check.

Test plan

  • All unit tests and FSC tests should pass.

@ozayr-zaviar ozayr-zaviar changed the title refact: optimizelyClient validity check fixed fix: optimizelyClient validity check fixed Nov 16, 2021
@coveralls
Copy link

coveralls commented Nov 16, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 99.57% when pulling cb3db8b on uzair/valid-fix into 1977527 on master.

@msohailhussain msohailhussain marked this pull request as ready for review November 17, 2021 23:36
@msohailhussain msohailhussain requested a review from a team as a code owner November 17, 2021 23:36
jaeopt
jaeopt approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@ozayr-zaviar ozayr-zaviar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ozayr-zaviar @coveralls @jaeopt